-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: truncate output of Groupby.groups #31388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 5 commits into
pandas-dev:master
from
MarcoGorelli:feature/groupby-repr-ellipses-1135
Jan 31, 2020
Merged
ENH: truncate output of Groupby.groups #31388
jreback
merged 5 commits into
pandas-dev:master
from
MarcoGorelli:feature/groupby-repr-ellipses-1135
Jan 31, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcoGorelli a few comments, the typing ones are not blockers.
Roll back added params to __pprint_dict. All logic now in __repr__ def. Make tests more general Remove unused line of code Move truncated dict repr to Index.groupby() Add correct groups object A few misc items for the linter Use pprint_thing in IndexGroupByGroups. Add whatsnew, docstring, and a couple typo fixes Update tests to expect pprint formatting. Use new config location. Small update in doc. Add nonsense to AUTHORS.md Revert "Add nonsense to AUTHORS.md" This reverts commit 9621669.
70df886
to
5eb98e4
Compare
a0bf2ac
to
b6b9751
Compare
simonjayhawkins
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MarcoGorelli lgtm.
thanks @MarcoGorelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrection of #24853. Have resolved conflicts and updated according to the last review it received. The original PR fixed some unrelated minor typos, so I've kept them in (and added a fix for another absolutely minor typo I'd noticed)
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff